Allow wparam and lparam in similar_names #7255
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @giraffate (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Thanks for opening PR! The code looks good to me. But I'm not familiar to Windows, so I don't know if it's reasonable. I would like to hear the opinions of others, here https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/Allow.20wparam.20and.20lparam.20in.20similar_names. |
|
@bors r+ It looks good, thanks! |
|
📌 Commit 2eafec1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
wparamandlparamare often used as generic parameter names in win32 (for example WindowProc). This PR adds them to the similar_names exception list.changelog: [
similar_names] don't treat wparam and lparam as similar